f5devcentral / f5-azure-saca

Secure Azure Computing Architecture for DoD (SACA) - Notional Secure Cloud Computing Architecture (SCCA) Deployment
MIT License
26 stars 40 forks source link

Create variables for Azure Service Fabric cluster endpoints #101

Closed Phydeauxman closed 4 years ago

Phydeauxman commented 4 years ago

The ARM templates have values that are hard coded for Azure Government. The concatenated values in the failoverCmdArray variable and the commandToExecute parameter use the hard coded value of .cloudapp.usgovcloudapi.net which is the endpoint for Azure Government.

Suggest making a parameter for this that can take an input and has a default value.

Azure Government = .cloudapp.usgovcloudapi.net Azure Commercial = .cloudapp.azure.com

Switching to variables for this value will also make the code portable to other environments https://docs.microsoft.com/en-us/azure/azure-government/documentation-government-developer-guide

Mikej81 commented 4 years ago

resolved in PR #105