f5devcentral / f5-azure-saca

Secure Azure Computing Architecture for DoD (SACA) - Notional Secure Cloud Computing Architecture (SCCA) Deployment
MIT License
26 stars 40 forks source link

Declarative Onboarding isn't working with BYOL #129

Closed sewalshmsft closed 3 years ago

sewalshmsft commented 3 years ago

I'm running basically the as-provided variables.tf, only changing the username/password and setting it to single tier deployment.

It looks like there's a bad character when outputting the declarative onboarding script when it executes as part of the Azure custom script extension at startup.

I've attached the startup log and the output JSONs in a zip to help you troubleshoot: startup-script.zip

Mikej81 commented 3 years ago

We have identified a bug in terraform 0.14.5 in Windows, does that match your environment? Seems there is ^M being added for CRLF on windows boxes.

Are you using the latest 3.0.2? We added a workaround to stream the characters out of the files.

Mikej81 commented 3 years ago

Ah, its removing the $schema attribute from the DO causing the failure. What version of TF are you using and on what OS? Are you using the powershell terminal or git-bash?

sewalshmsft commented 3 years ago

Thanks for the quick response Mike. I'm running TF 0.13.5 on Windows 10. PowerShell terminal through Visual Code.

Mikej81 commented 3 years ago

We have been noticing some odd behavior lately with windows machines. Ill see if I can figure out a workaround.

Mikej81 commented 3 years ago

@sewalshmsft closing out, patched in DO / AS3 repos. Removed $Schema attributes from declarations. Should run now, tested good.

sewalshmsft commented 3 years ago

Thanks Mike, I had a good deploy with TF 0.14.5 + git-bash on Windows 10.