search

fabacab / fetlife-aslsearch

Greasemonkey user script offering an interface to perform pseudo-automatic searches of the FetLife.com user base filtered by age, sex, location, and role.
59 stars 27 forks source link

Plugin UI polish, classic mode rename and user warning #39

Closed PrivatePuffin closed 6 years ago

PrivatePuffin commented 6 years ago
  1. I polished some UI elements like the lack of linebreaks, lines etc.
  2. I renamed classic mode to legacy mode, to make it clear which is the "prefered" option
  3. I added a warning that should inform users the legacy mode could lead to a higher detectability, to prevent the issues filed at git due to user error. Fixes #26
  4. changed version number to 1.4.7
  5. Cleanly, Neatly Squashed.
fabacab commented 6 years ago

This is nice, thank you.

The only thing is you don't need to use <br /> elements, because these could (and should) be styled in CSS. Would you mind cleaning the HTML and using CSS to define the spacing? Thanks!

PrivatePuffin commented 6 years ago

I understand you wanting the starting <br> in css as margin.

But in-text linebreaks, should not be added by splitting it in multiple divs. So yes I will replace the<br> with the margin before and after text divs.

But the in-text linebreaks should be <br>...