fabi1cazenave / webL10n

Client-side internationalization / localization library
http://fabi1cazenave.github.com/webL10n/
279 stars 71 forks source link

Add multi-line property file reading #65

Closed mattrayner closed 8 years ago

mattrayner commented 9 years ago
mattrayner commented 9 years ago

I'm working on implementing these changes and improvements now

mattrayner commented 9 years ago

@Rob--W - I've implemented some of your changes, I feel the helper functions greatly improve the readability of the file so have left those in - do you feel I need to take them out?

Rob--W commented 9 years ago

@mattrayner I'm usually favourable towards decomposition of functions, but in this case the original function (nextEntry) is still manageable, while the alternative decomposed functions appear more complex and contain bugs.

PRs should not break backwards compatibility if possible, that's why this method supports synchronous and asynchronous imports.