Heretic: do not crash if the wrong side of the door is pushed

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.

https://fabiangreffrath.github.io/crispy-homepage

GNU General Public License v2.0

807 stars 132 forks source link

Heretic: do not crash if the wrong side of the door is pushed #1191

Closed JNechaevsky closed 7 months ago

JNechaevsky commented 8 months ago

Very rare case and pretty straight-forward fix, but as always, few remarks:

The fix itself is a carbon copy from Crispy Doom, except using printf, not fprintf (I belive printing into a file no longer needed since SDL2 version).
Testing map, DR door on one sided line is in front of the player view: dr-1side.zip

Fixes https://github.com/fabiangreffrath/crispy-doom/issues/1188, thanks @Catoptromancy for pointing out.

fabiangreffrath commented 7 months ago

Thank you!

except using printf, not fprintf (I belive printing into a file no longer needed since SDL2 version).

Erm, it's not printing to a file but to stderr, i.e. a file pointer reserved for error messages printed to the terminal. 😉

JNechaevsky commented 7 months ago

I know, I know. Still wasn't in a good condition back in that day and done things automatically. If you wish, I'll revert it back to fprintf approach to be in complete sync with implementation from Doom.

fabiangreffrath commented 7 months ago

Yes, please.