search

fabiangreffrath / crispy-doom

Crispy Doom is a limit-removing enhanced-resolution Doom source port based on Chocolate Doom.
https://fabiangreffrath.github.io/crispy-homepage
GNU General Public License v2.0
807 stars 132 forks source link

Doom: fix blinking of drawing Tower of Babel on intermission screen #1197

Closed JNechaevsky closed 7 months ago

JNechaevsky commented 7 months ago

This is a very, very minor thing, but once you'll notice, it can't be unseen. Fortunately, the fix is very easy - we have to initialize animation variables (a->ctr = -1;) just once, when we are entering tally screen, and don't touch them when switching to "Entering" screen.

However! This fixes not only Tower of Babel itself, but whole animations on all three episodes. But such breaks in all other animations will be hard to notice since they are small. Probably red sky in E3 background is more or less noticeable.

Easiest way to see tower's blinking is an exit from E2M7, as in this state tower is almost built and it's sprite is tall enough.

Initial suggestion and video example: in https://github.com/JNechaevsky/international-doom/issues/122

JNechaevsky commented 7 months ago

Thanks for accepting! Should it be fixed in Woof as well? The case and fix is 100% identical there.

fabiangreffrath commented 7 months ago

Sure, why not. Would you file a PR?

JNechaevsky commented 7 months ago

Of course, gladly, will do soon.