search

fabianmichael / kirby-markdown-field

Super-sophisticated markdown editor for Kirby 3, community built.
Other
162 stars 14 forks source link

Kirby revert/undo button not working #47

Closed littlemermaidfromthesea closed 5 years ago

littlemermaidfromthesea commented 5 years ago

Could it be that the revert/undo button isn't working properly? RC3, Safari, Firefox

sylvainjule commented 5 years ago

Some additional details might be useful: what do you mean by not working? Nothing happens ? Reverts to the wrong content?

I don't seem to have issues with revert on FF or Safari, could you guide me through some exact steps causing issues for you?

littlemermaidfromthesea commented 5 years ago

Hey! Yeah like you said, the field is not reverting any changes, nothing happens. The content just stays the same as after editing. I only tested the link and bold button though. Oh, it's a multilanguage-installation though – English and German.

Today I ran into another issue in Safari only: if the textarea is bigger than the window, after scrolling and then clicking on a button in the toolbar, the toolbar loses focus and its sticky position. According to the helpdesk slack, this is a Kirby issue not a plugin issue.

sylvainjule commented 5 years ago

I am also testing it in a multilanguage installation though, and don't have the revert issue. Any other plugin installed? If so, could you try without them? Any error thrown in the console? Does it work again if you switch the field's type from markdown to textarea?

I have identified the second safari issue and am pushing a fix, thanks for the heads up!

littlemermaidfromthesea commented 5 years ago

No, this is the only plugin I installed. It works as intended if it's a regular textarea field. Thanks for pushing a fix!

sylvainjule commented 5 years ago

Could reproduce it when there are 2+ fields on the page. Will look into it.

sylvainjule commented 5 years ago

https://github.com/sylvainjule/kirby-markdown-field/commit/cbe34ee51e340ead470652c871c485e41b2a0171