search

fabiospampinato / voby-simple-router

A simple isomorphic router for Voby.
MIT License
6 stars 3 forks source link

`children` routes are not working #1

Closed sibbng closed 1 year ago

sibbng commented 1 year ago

Hi, it seems children routes are not working at all. I tested both static and dynamic routes but no luck. Defining at top level works.

Reproduction: https://stackblitz.com/edit/vitejs-vite-ms9fna?file=src/main.tsx

fabiospampinato commented 1 year ago

It should be fixed in v1.4.1, thanks 👍 I had two lines in the wrong order here:

https://github.com/fabiospampinato/voby-simple-router/blob/9b91a59c300457f5312da4c5275e19f706c25f6d/src/hooks/use_router.ts#L23-L25

sibbng commented 1 year ago

Thanks for quick fix 🙏