fabiospampinato / vscode-terminals

An extension for setting-up multiple terminals at once, or just running some commands.
MIT License
121 stars 19 forks source link

Recycle=true not recycling #63

Open Marcel0024 opened 2 years ago

Marcel0024 commented 2 years ago

I have these two terminals:

{
  "autorun": true,
  "autokill": true,
  "terminals": [
     {
        "name": "npm start",
        "command": "npm start",
        "recycle": true
      },
      {
        "name": "npm test",
        "command": "npm test -- --coverage --watch-all",
        "recycle": true
      }
  ]
}

After restarting VS code, it just makes new terminals: image

Expected behaviour when using recycle: true the old terminals will be reused and not create a new one

gbny commented 2 years ago

I fixed this by disabling Persistent Session Revive in settings:

In VSCode settings ( Ctrl+, ) : Filter for "@feature:terminal Persistent Session Revive Process" and set it to "never". This prevents VSCode from opening duplicate sets of terminals on application launch.

Now my currently open Terminals Manager terminals recycle properly on application launch :)

Marcel0024 commented 2 years ago

@gbny

Nice! thanks that works. Maybe it should be documented.

simensol commented 2 years ago

@gbny's workaround doesn't work when I use VSC's developer container, even when persistent bash history is enabled.