Closed aolney closed 7 years ago
alfonsogarciacaro
commented
7 years ago Sorry, I'm not fully understanding the intention of the PR. Where will the updated sample be kept? Are you planning to take it directly from the commit later? And, can't 0.6.x just be branched from the commit previous to the sample update?
aolney
commented
7 years ago I apologize I think I completely misunderstood. Does a PR in this context means merging this branch into master? That is not what I intended. I intended you to approve the creation of this branch, and perhaps a PR is not necessary for that.
Yes you're right I could have branched from the commit previous to the sample update. My intention is for the updated "material-ui" sample to continue to live on master, along with the updated 1.0 samples I will be pushing. Sorry I'm a bit of a noob on github procedures. After this PR I just pushed a new sample to master and didn't realize that it wouldn't create a PR, though in hindsight I should have. Do you want me to kill this PR and branch from the previous commit as you suggested? Or should I just kill this PR and let this new branch continue to exist?
alfonsogarciacaro
commented
7 years ago No worries, I also learnt about Github PRs very recently and I cannot say I'm a git expert at all. Yes in this case, the PR would merge 0.6.x into master (you can see it under the title). I thing Github gives you the option of which branch you want to merge into which, but by default the target is usually master.
Yes, I would close the PR and keep the 0.6.x (or 0.7.x) branch for samples working with the previous Fable version. Hopefully Fable 1.0 is stable very soon so we don't have to maintain two branches :)
0.6.x is a legacy branch before moving master to 1.0. Because material ui sample was already 1.0, I changed it back to 0.6.x for the legacy branch.