alfonsogarciacaro
commented
8 years ago Fantastic, thank you! I need to give this a try, looks super cool :clap: The PR looks fine to me, there're some merge commits but I think the only way to avoid this is by rebasing which can be a bit confusing sometimes. In any case, I usually use the Squash and merge Github feature to merge the PRs so it will appear as a single commit in master history.
If you're interested in collaborating more with Fable, I've sent you an invitation to join the team! 👍 If you accept it you'll have write access to this repo. It's probably better if we keep using PRs to update master but you can work on custom branches directly in the repo if you want :)
aolney
This PR ports the Stickman Ventures Ginger Demo , viewable here to Electron via fable.
A few things from Ginger were left out (google analytics/bower related) and a few fixes made (some modal windows weren't closing).
The license is Apache 2 b/c that's what Ginger is. Also note they have a CC Noncommercial on the 3D assets. I left that license right where they did in the source tree.
PS Please let me know if I can do something better with these PRs. I found that if I merged with upstream GitHub can automatically merge, but there seems to be a lot of old commit history below.