search

fabric8-services / fabric8-tenant-jenkins

Generates Jenkins tenant namespace YAML
Apache License 2.0
2 stars 14 forks source link

Fixes build starts with Maven artifactIds fails #103

Closed hrishin closed 6 years ago

hrishin commented 6 years ago

Updated OpenShift and k8s deployment to add ENV var for Kubernetes pipeline Jenkins plugin.

Fixes https://github.com/openshiftio/openshift.io/issues/3784

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

hrishin commented 6 years ago

@sthaha @rupalibehera @piyush1594 could you review it, please?

sthaha commented 6 years ago

@hrishin lgtm but could you please amend the commit to add 

Fixes openshiftio/openshift.io#3784
hrishin commented 6 years ago

Sure

On Thu, Jul 12, 2018 at 10:46 AM sthaha notifications@github.com wrote:

@sthaha requested changes on this pull request.

the commit message must have a link to the issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fabric8-services/fabric8-tenant-jenkins/pull/103#pullrequestreview-136505023, or mute the thread https://github.com/notifications/unsubscribe-auth/AbSj-plmDsW4BNXwrx7x-6aAvBplUnk7ks5uFtuNgaJpZM4VHLa5 .

-- Hrishikesh | +91 7276 342274 | IRC: hshinde

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

hrishin commented 6 years ago

@sthaha can we close it as well?