fabric8io / docker-maven-plugin

Maven plugin for running and creating Docker images
https://dmp.fabric8.io
Apache License 2.0
1.88k stars 642 forks source link

noCache property ignored when using buildx #1679

Open Mikep86 opened 1 year ago

Mikep86 commented 1 year ago

Description

When buildx is enabled, docker-maven-plugin ignores the docker.noCache property. I tried setting the property via the Maven command line and via buildOptions in the POM file with the same result, the docker build cache is used in both cases:

mvn clean verify -Ddocker.noCache=true
<configuration>
    <images>
        <image>
                ...
                <buildx>
                    <platforms>
                        <platform>linux/amd64</platform>
                        <platform>linux/arm64</platform>
                    </platforms>
                </buildx>
                <buildOptions>
                    <noCache>true</noCache>
                <buildOptions>
            </build>
        </image>
    </images>
</configuration>

Info

poikilotherm commented 5 months ago

This seems to be resolved with v0.44.0

rohanKanojia commented 5 months ago

@Mikep86 : Could you please try with v0.44.0 ?

rohanKanojia commented 5 months ago

@Mikep86 : I remember I've merged a pull request for this functionality https://github.com/fabric8io/docker-maven-plugin/pull/1717