fabric8io / gofabric8

CLI used when working with fabric8 running on Kubernetes or OpenShift
https://fabric8.io/
Apache License 2.0
147 stars 72 forks source link

Wrong extension for minishift latest version. #643

Closed pemmasanikrishna closed 6 years ago

pemmasanikrishna commented 6 years ago

.exe is getting appended to the latest version for windows, which is actually a zip file. making the url "https://github.com/minishift/minishift/releases/download/v1.12.0/minishift-1.12.0-windows-amd64.zip.exe..." which is incorrect.

jaseemabid commented 6 years ago

@pemmasanikrishna Thanks for the PR. Looks like this slipped through because none of us tested this on windows. LGTM 👍

cc: @chmouel