fac-13 / jeth

Find jobs near you :computer:
https://jeth.herokuapp.com/
1 stars 2 forks source link

Function naming #32

Open eliasmalik opened 6 years ago

eliasmalik commented 6 years ago

https://github.com/fac-13/jeth/blob/55aa475205ea69a649432a9c9cfd0b7e1854d083/src/logic.js#L4

Usually helps to be more descriptive when naming functions. filter is a very generic name, which would be fine if the function was doing something generic, but the logic is actually very specific to your application. Without looking at the function body, I'd have no idea what it was filtering.