facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

move deprecation warnings to SurrogateSpec and pass surrogate_spec to Surrogate #3025

Closed sdaulton closed 3 weeks ago

sdaulton commented 3 weeks ago

Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated.

Reviewed By: saitcakmak

Differential Revision: D65321401

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65321401

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65321401

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.42268% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.60%. Comparing base (8231273) to head (c8fb1ba).

Files with missing lines Patch % Lines
ax/models/torch/botorch_modular/surrogate.py 96.15% 3 Missing :warning:
ax/models/torch/botorch_modular/model.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3025 +/- ## ========================================== - Coverage 95.60% 95.60% -0.01% ========================================== Files 483 483 Lines 49012 49112 +100 ========================================== + Hits 46859 46954 +95 - Misses 2153 2158 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65321401

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65321401

facebook-github-bot commented 3 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65321401

facebook-github-bot commented 3 weeks ago

This pull request has been merged in facebook/Ax@647bdc5e04408bdae70129979958e5cfc30256c4.