Closed sdaulton closed 3 weeks ago
This pull request was exported from Phabricator. Differential Revision: D65321401
This pull request was exported from Phabricator. Differential Revision: D65321401
Attention: Patch coverage is 97.42268%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 95.60%. Comparing base (
8231273
) to head (c8fb1ba
).
Files with missing lines | Patch % | Lines |
---|---|---|
ax/models/torch/botorch_modular/surrogate.py | 96.15% | 3 Missing :warning: |
ax/models/torch/botorch_modular/model.py | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was exported from Phabricator. Differential Revision: D65321401
This pull request was exported from Phabricator. Differential Revision: D65321401
This pull request was exported from Phabricator. Differential Revision: D65321401
This pull request has been merged in facebook/Ax@647bdc5e04408bdae70129979958e5cfc30256c4.
Summary: See title. This avoids defining the same arguments in two places, per feedback from Sait. Moving deprecation warnings to SurrogateSpec means warnings are raised raised while specifying the model rather than when it is instantiated.
Reviewed By: saitcakmak
Differential Revision: D65321401