search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Error out if Logit scale parameters are not transformed in ModelBridge #3046

Closed saitcakmak closed 2 weeks ago

saitcakmak commented 2 weeks ago

Summary: For log-scale parameters, we had an error but a similar error was missing for logit-scale parameters, which would make it possible to silently ignore the logit_scale option for these parameters. Extended the error to cover both parameter types.

Differential Revision: D65682314

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65682314

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.65%. Comparing base (2322259) to head (80cde1b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3046 +/- ## ======================================= Coverage 95.65% 95.65% ======================================= Files 485 485 Lines 49198 49203 +5 ======================================= + Hits 47058 47064 +6 + Misses 2140 2139 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/Ax@3db6b005ee2b37d51fd352eb2fae8f450ece8d77.