search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Move oracle-related logic from `BenchmarkProblem` to `benchmark.py` #3049

Closed esantorella closed 2 weeks ago

esantorella commented 2 weeks ago

Summary: This moves methods on BenchmarkProblem to functions in benchmark.py without modifying them beyond changing "self" to "problem." This is not that interesting in itself; I'm doing this to make D65662132 easier to review.

Differential Revision: D65679443

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65679443

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 96.24060% with 10 lines in your changes missing coverage. Please review.

Project coverage is 95.68%. Comparing base (03f1b95) to head (790bd3e).

Files with missing lines Patch % Lines
ax/utils/testing/benchmark_stubs.py 86.27% 7 Missing :warning:
ax/benchmark/benchmark_runner.py 85.71% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3049 +/- ## ========================================== + Coverage 95.65% 95.68% +0.02% ========================================== Files 485 485 Lines 49166 49298 +132 ========================================== + Hits 47029 47169 +140 + Misses 2137 2129 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65679443

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65679443

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/Ax@8d5eb71b3ffaa5af882206be2f365193f2aafbf9.