search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Move stop_trial_run from Scheduler to Experiment #3050

Closed paschai closed 2 weeks ago

paschai commented 2 weeks ago

Summary: as titled - stop_trial_run should reside within the Experiment class because the components required to stop trials are native attributes of Experiment

Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (cbf322b) to head (be3a01e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3050 +/- ## ======================================= Coverage 95.68% 95.68% ======================================= Files 486 486 Lines 49300 49320 +20 ======================================= + Hits 47172 47194 +22 + Misses 2128 2126 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65777846

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/Ax@e20c48ef4e319a64aa224b9be452ed00631d9eee.