search

facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Use a dataclass to store data returned by benchmark run #3052

Closed esantorella closed 2 weeks ago

esantorella commented 2 weeks ago

Summary:

benchmark/dataclasses.py

Introduces a small dataclass to store Ys, Ystds, and outcome_names, rather than keeping them in a dict. This helps with typing

BenchmarkRunner, BenchmarkMetric:

Reviewed By: saitcakmak

Differential Revision: D65280187

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65280187

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.68%. Comparing base (df94a3d) to head (bdca7f4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3052 +/- ## ======================================= Coverage 95.68% 95.68% ======================================= Files 485 486 +1 Lines 49295 49307 +12 ======================================= + Hits 47168 47181 +13 + Misses 2127 2126 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65280187

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65280187

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65280187

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/Ax@4d517e505447c38f61104726f0641d1419860fea.