facebook / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
102.58k stars 26.8k forks source link

When you use this plugin you must install `typescript`? #11724

Open darewreck54 opened 2 years ago

darewreck54 commented 2 years ago

I posted the question in the discussion. It's not clear if this is a bug or if I'm just doing it incorrect. https://github.com/facebook/create-react-app/discussions/11704

Describe the bug

I clone the create-react-app repo and ran the following commends:

npx create-react-app tester4 --scripts-version file:./create-react-app/packages/react-scripts --template file:./create-react-app/packages/cra-template-typescript

....

cd tester4
yarn start                                                                           
yarn run v1.22.17
$ react-scripts start
**When you use this plugin you must install `typescript`.**
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I would expect it to work similar to when you just call npx create-react-app tester4 --typescript, but it's not.

Questions 1) isn't npx create-react-app tester4 --typescript the same as npx create-react-app tester4 --scripts-version file:./create-react-app/packages/react-scripts --template file:./create-react-app/packages/cra-template-typescript 2) When you see the message When you use this plugin you must installtypescript` what are you suppose to do. Do you just install typescript in the custom --script-version. Like in this case, isn't-scripts-version file:./create-react-app/packages/react-scripts` the default anyways?

Thanks, Derek

quisido commented 2 years ago

The react-dev-utils package is using an outdated version of fork-ts-checker-webpack-plugin. The published version uses 4.x, while the unpublished code in this repo uses 6.x. The 6.x version needs to be published. I don't know what the blocker is for publishing it.

darewreck54 commented 2 years ago

I think the new release 5.0 addressed the issue.