search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
816 stars 514 forks source link

Remove deprecated usage of strlen(). #567

Closed grasmash closed 1 year ago

facebook-github-bot commented 1 year ago

Hi @grasmash!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

natewiebe13 commented 1 year ago

The code in main should have already resolved the deprecation, it just hasn't been tagged yet. Does this resolve the deprecation in a different way than what's currently in main?

grasmash commented 1 year ago

Didn't realize there was already code in main for this. Main does need changes to src/FacebookAds/Object/AbstractCrudObject.php.

natewiebe13 commented 1 year ago

That file along with some others was updated in https://github.com/facebook/facebook-business-sdk-codegen/pull/50

The next release they'll import the latest codegen changes and I believe that should resolve all of the remaining 8.1 deprecations.