search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.13k stars 2.99k forks source link

htmlentities() fails on invalid multibyte sequences #3583

Closed milesj closed 9 years ago

milesj commented 10 years ago

I don't know enough about this to know figure out where the issue is at but here's the test that blows up.

https://github.com/milesj/decoda/blob/master/tests/Decoda/DecodaTest.php#L249

And the error in HHVM: https://travis-ci.org/milesj/decoda/jobs/33451026

And HHVM nightly: https://travis-ci.org/milesj/decoda/jobs/33451027

I believe it may be caused by ENT_SUBSTITUTE. https://github.com/milesj/decoda/blob/master/src/Decoda/Decoda.php#L407

paulbiss commented 9 years ago

Fix is up D29301

milesj commented 9 years ago

Cheers!