Version 1.1.0.51 does not format correctly for style "Kotlinlang"

[kay-horst]

• Reformat code, formerly formatted with "Kotlinlang"-style => formatting is changed
• Apply Gradle Spotless plugin (./gradlew spotlessapply) => Formatting back to old (correct) state

Settings for the Spotless plugin:

    kotlin {
        target 'src/main/**/*.kt'
        ktfmt().kotlinlangStyle()
    }

The workaround mentioned in #486 did not work for me.

[darioseidl]

This was also reported here https://github.com/facebook/ktfmt/issues/490 and is supposedly fixed, but the fix is not released yet.

I'm hoping they release it soon, so that the IntelliJ plugin, gradle-ktfmt and ktfmt jar all result in the same formatting again.

[theovier]

Any news on a possible release for the mentioned fix? It's quite annoying to work around this.

[rock3r]

https://github.com/facebook/ktfmt/releases/tag/v0.52 🎉

[rock3r]

Ah no, release failed :(

[hick209]

v0.52 is out now. Let us know if you still face the issues reported here

[hick209]

Also make sure that spotless is using the same version of ktfmt that you are using in your IDE

[darioseidl]

v0.52 is out now. Let us know if you still face the issues reported here

It works for me now: ktfmt 0.52, the IntelliJ plugin, and ktfmt-gradle 0.20.1 all produce the same result.

[kay-horst]

The plugin now adds commas after each last parameter of a method, if each parameter is on its own line:

class Foo(
    private val value1: String,
    private val value2: String,
    private val value3: String,
    private val value3: String
) {

becomes

class Foo(
    private val value1: String,
    private val value2: String,
    private val value3: String,
    private val value3: String,
) {

It was not the case before.

Is this standard behaviour?

[hick209]

@kay-horst it is as now it handles trailing lambdas for the kotlinlang style (see #442)