search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
20.01k stars 1.71k forks source link

AutoLink should also respect the default behavior of toogle link command #4674

Open WinmezzZ opened 1 year ago

WinmezzZ commented 1 year ago

AutoLink should also respect the default behavior of toogle link.

AutoLink Plugin is a nice plugin when we need transform a http url to an html link element, but sometimes we want to cancel the link for an url, just for showing but not allowed to click

https://github.com/facebook/lexical/assets/40154766/f412ca3e-b404-41b2-afc6-e26dfc2002e8

ankitpawar03 commented 1 year ago

I want to work on this issue please assign me this.

thegreatercurve commented 1 year ago

@ankitpawar03 Happy for you to take a look. Assigned it to you.

ankitpawar03 commented 1 year ago

@ankitpawar03 Happy for you to take a look. Assigned it to you.

I ran it on my local system and searched on the source code but couldn't get how to disable auto-link, can you help me with it?

ankitpawar03 commented 1 year ago

@ankitpawar03 Happy for you to take a look. Assigned it to you.

Thank you for giving me this opportunity, but I am unable to resolve this issue yet, so I am unassigning myself from this...

Infinity8sailor commented 1 year ago

@thegreatercurve, Hey, I was working on this issue but realised that even if we toggle the auto link, it will automatically going to consider it again. I mean, we might need to consider it auto-link for the first time but somehow need to ignore it for the second time.

hazirmagron commented 7 months ago

@thegreatercurve, Hey, I was working on this issue but realised that even if we toggle the auto link, it will automatically going to consider it again. I mean, we might need to consider it auto-link for the first time but somehow need to ignore it for the second time.

Have this approach been given up on?

It is how I would expect it to work. Not having the ability to have both 1) auto link copy/pasted links and 2) remove the anchor is poor UX. Ideally both is possible through this approach.

juliana-samoilenko commented 2 months ago

It looks like the problem was solved here https://github.com/facebook/lexical/issues/5607

is that right?