search

facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
118.43k stars 24.25k forks source link

Platform.constants.reactNativeVersion.prerelease should be a string #45393

Closed necolas closed 2 months ago

necolas commented 2 months ago

Description

The latest 0.75 RC has prerelease as a number, 0, but it should be typed and set as a string.

Steps to reproduce

https://github.com/facebook/react-strict-dom/pull/163

React Native Version

0.75.0-rc4

Affected Platforms

Runtime - Android

Output of npx react-native info

.

Stacktrace or Logs

.

Reproducer

https://github.com/facebook/react-strict-dom/pull/163

Screenshots and Videos

No response

github-actions[bot] commented 2 months ago
:warning: Missing Reproducible Example
:information_source: We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.
NickGerleman commented 2 months ago

This was fixed by https://github.com/facebook/react-native/commit/95d9cdf228e33d5651f41ebf5e14e80962fae118

necolas commented 2 months ago

Does that commit need to be cherry picked for 0.75 then? The current RC is setting the value to 0

NickGerleman commented 2 months ago

If we want the fix in 0.75 RCs, then we would want to make a pick request here: https://github.com/reactwg/react-native-releases/issues/new?assignees=&labels=Type%3A+Pick+Request&projects=&template=pick_request_form.yml&title=%5B0.XX%5D+Title

The issue would also naturally resolve itself in final 0.75 release (since it's not a prerelease), or 0.76 RC.

necolas commented 2 months ago

The issue would also naturally resolve itself in final 0.75 release (since it's not a prerelease), or 0.76 RC.

Ok that works. Thanks for the clarification