facebook / react-strict-dom

React Strict DOM (RSD) standardizes the development of styled React components for web and native.
https://facebook.github.io/react-strict-dom
MIT License
3.2k stars 161 forks source link

Avoid setting direction:auto #141

Closed necolas closed 5 months ago

necolas commented 5 months ago

The style 'direction:auto' is not supported in React Native and causes Fabric to log warnings.

github-actions[bot] commented 5 months ago

compressed-size: runtime library

Size change: -0.00 kB Total size: 19.16 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/native/index.js 15.27 (48.99) -0.00 (-0.07) -0.0% (-0.1%)
View unchanged | Filename: gzip (minify) | kB size | kB change | % change | | :--- | :--- | :--- | :--- | | `./packages/react-strict-dom/dist/dom/index.js` | **2.94** (8.79) | **0.00** (0.00) | **0.0%** (0.0%) | | `./packages/react-strict-dom/dist/dom/runtime.js` | **0.95** (2.33) | **0.00** (0.00) | **0.0%** (0.0%) |
github-actions[bot] commented 5 months ago

RSD benchmarks (for native)

Base 87bc569d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,064,342 0.23 94
small with units 496,276 0.48 94
small with variables 653,562 0.17 94
several small 345,803 0.33 94
large 304,899 0.43 92
large with polyfills 223,368 0.19 96
complex 120,462 0.43 93
unsupported 238,227 0.21 97
css.createTheme ops/sec deviation (%) samples
simple theme 222,166 0.15 93
polyfill theme 210,622 0.22 97
css.props ops/sec deviation (%) samples
small 185,721 0.21 93
small with units 160,224 0.18 95
small with variables 92,085 0.65 95
small with variables of units 68,792 0.29 94
large 61,851 0.27 97
large with polyfills 24,174 0.19 94
complex 14,800 0.25 97
unsupported 65,250 0.24 95
simple merge 150,062 0.12 98
wide merge 11,553 0.26 96
deep merge 11,434 0.29 93
internals ops/sec deviation (%) samples
extractStyleThemes 460,107 0.15 97
flattenStyle 679,132 0.57 97

Patch a6f51ca6

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,045,771 0.21 96
small with units 489,259 0.42 97
small with variables 642,609 0.15 98
several small 342,313 0.30 96
large 301,651 0.24 97
large with polyfills 220,311 0.19 96
complex 119,982 0.14 97
unsupported 236,739 0.19 94
css.createTheme ops/sec deviation (%) samples
simple theme 222,026 0.37 95
polyfill theme 209,878 0.17 95
css.props ops/sec deviation (%) samples
small 184,236 0.68 94
small with units 159,146 0.14 96
small with variables 91,296 0.12 96
small with variables of units 68,445 0.51 94
large 61,562 0.14 94
large with polyfills 23,846 0.18 95
complex 14,720 0.41 95
unsupported 65,034 0.29 95
simple merge 150,473 0.12 94
wide merge 11,631 0.20 98
deep merge 11,516 0.29 96
internals ops/sec deviation (%) samples
extractStyleThemes 460,033 0.12 94
flattenStyle 685,272 0.15 93
github-actions[bot] commented 5 months ago

RSD benchmarks (for native)

Base 87bc569d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,031,390 0.31 91
small with units 492,746 0.34 96
small with variables 654,561 0.42 95
several small 338,850 0.78 97
large 297,994 0.25 93
large with polyfills 224,125 0.19 91
complex 121,067 0.16 95
unsupported 236,101 0.32 98
css.createTheme ops/sec deviation (%) samples
simple theme 223,533 0.19 97
polyfill theme 211,329 0.17 97
css.props ops/sec deviation (%) samples
small 185,432 0.15 96
small with units 160,046 0.14 96
small with variables 92,655 0.14 96
small with variables of units 68,926 0.31 94
large 61,479 0.18 97
large with polyfills 24,088 0.20 93
complex 14,807 0.33 95
unsupported 65,216 0.52 93
simple merge 150,275 0.15 96
wide merge 11,605 0.23 97
deep merge 11,477 0.18 96
internals ops/sec deviation (%) samples
extractStyleThemes 459,810 0.27 93
flattenStyle 682,828 0.13 97

Patch 810cd89d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,030,974 0.76 92
small with units 499,088 0.22 93
small with variables 645,249 0.32 94
several small 337,020 2.31 94
large 301,286 0.22 93
large with polyfills 223,795 0.16 95
complex 120,690 0.12 94
unsupported 237,745 0.18 94
css.createTheme ops/sec deviation (%) samples
simple theme 223,024 0.18 95
polyfill theme 211,348 0.48 96
css.props ops/sec deviation (%) samples
small 186,517 0.13 96
small with units 160,197 0.13 96
small with variables 92,611 0.15 94
small with variables of units 68,871 0.19 94
large 61,327 0.30 95
large with polyfills 24,072 0.19 92
complex 14,851 0.18 97
unsupported 64,318 0.34 93
simple merge 148,615 0.13 95
wide merge 11,656 0.14 97
deep merge 11,499 0.26 95
internals ops/sec deviation (%) samples
extractStyleThemes 459,896 0.19 98
flattenStyle 685,537 0.11 95
github-actions[bot] commented 5 months ago

RSD benchmarks (for native)

Base 87bc569d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,058,776 0.36 95
small with units 495,859 0.23 94
small with variables 663,286 0.17 97
several small 341,563 0.77 93
large 305,367 0.23 96
large with polyfills 225,567 0.18 94
complex 119,823 0.15 94
unsupported 238,683 0.20 96
css.createTheme ops/sec deviation (%) samples
simple theme 226,061 0.17 96
polyfill theme 213,377 0.20 95
css.props ops/sec deviation (%) samples
small 184,482 0.17 96
small with units 159,450 0.16 96
small with variables 91,973 0.13 97
small with variables of units 68,495 0.43 97
large 61,176 0.17 97
large with polyfills 24,110 0.21 95
complex 14,770 0.45 96
unsupported 64,992 0.30 95
simple merge 149,726 0.27 97
wide merge 11,526 0.18 96
deep merge 11,404 0.28 94
internals ops/sec deviation (%) samples
extractStyleThemes 457,460 0.17 96
flattenStyle 681,819 0.07 94

Patch 2a31173d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,060,378 0.21 96
small with units 497,477 0.28 94
small with variables 657,662 0.15 97
several small 345,788 0.31 96
large 303,014 0.26 96
large with polyfills 226,942 0.19 95
complex 120,671 0.12 98
unsupported 239,155 0.21 95
css.createTheme ops/sec deviation (%) samples
simple theme 227,224 0.17 94
polyfill theme 214,350 0.29 94
css.props ops/sec deviation (%) samples
small 185,233 0.18 94
small with units 159,619 0.15 97
small with variables 92,640 0.14 90
small with variables of units 69,259 0.30 95
large 61,310 0.16 96
large with polyfills 24,006 0.20 97
complex 14,783 0.20 94
unsupported 64,564 0.32 94
simple merge 147,877 0.75 94
wide merge 11,521 0.20 98
deep merge 11,399 0.25 92
internals ops/sec deviation (%) samples
extractStyleThemes 454,074 1.37 94
flattenStyle 683,787 0.09 98
github-actions[bot] commented 5 months ago

RSD benchmarks (for native)

Base 87bc569d

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,055,924 0.22 94
small with units 486,120 1.21 91
small with variables 661,794 0.58 96
several small 338,982 1.10 92
large 299,875 0.82 92
large with polyfills 222,549 0.19 95
complex 119,001 0.19 95
unsupported 237,419 0.23 96
css.createTheme ops/sec deviation (%) samples
simple theme 222,467 0.18 96
polyfill theme 210,311 0.17 94
css.props ops/sec deviation (%) samples
small 183,371 0.20 94
small with units 159,788 0.22 96
small with variables 91,420 0.66 92
small with variables of units 68,583 0.32 95
large 60,994 0.98 95
large with polyfills 24,216 0.29 95
complex 14,695 0.51 92
unsupported 65,141 0.33 95
simple merge 149,427 0.21 92
wide merge 11,525 0.49 91
deep merge 11,400 0.53 94
internals ops/sec deviation (%) samples
extractStyleThemes 453,908 0.50 98
flattenStyle 682,632 0.17 98

Patch aceae3f9

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,055,739 0.27 95
small with units 497,655 0.22 96
small with variables 662,426 0.78 95
several small 346,148 0.33 94
large 303,894 0.29 95
large with polyfills 221,931 0.20 96
complex 118,033 0.21 97
unsupported 237,188 0.40 93
css.createTheme ops/sec deviation (%) samples
simple theme 222,504 0.19 91
polyfill theme 209,566 0.46 95
css.props ops/sec deviation (%) samples
small 183,992 0.25 96
small with units 158,877 0.26 94
small with variables 91,435 0.25 94
small with variables of units 68,566 0.47 97
large 61,368 0.26 95
large with polyfills 24,041 0.32 92
complex 14,693 0.50 95
unsupported 64,981 0.33 94
simple merge 148,685 0.43 96
wide merge 11,481 0.49 93
deep merge 11,292 1.23 93
internals ops/sec deviation (%) samples
extractStyleThemes 458,060 0.14 93
flattenStyle 679,057 0.19 95
github-actions[bot] commented 5 months ago

RSD benchmarks (for native)

Base 41ea2a26

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,048,997 0.60 93
small with units 474,488 2.03 94
small with variables 656,186 0.95 97
several small 341,828 0.28 96
large 304,106 0.28 93
large with polyfills 179,933 0.45 95
complex 110,040 0.13 96
unsupported 239,940 0.35 92
css.createTheme ops/sec deviation (%) samples
simple theme 224,866 0.74 94
polyfill theme 213,209 0.16 94
css.props ops/sec deviation (%) samples
small 185,704 0.17 96
small with units 160,481 0.16 97
small with variables 91,954 0.81 97
small with variables of units 68,313 0.35 96
large 61,296 0.21 94
large with polyfills 21,026 0.17 95
complex 12,146 0.48 98
unsupported 64,984 0.23 92
simple merge 151,441 0.09 98
wide merge 10,360 0.28 97
deep merge 10,240 0.20 97
internals ops/sec deviation (%) samples
extractStyleThemes 462,243 0.21 98
flattenStyle 656,233 0.13 97

Patch 27ea339f

react-strict-dom@0.0.15 benchmarks npm run build:benchmarks && node --jitless benchmarks/run.js

react-strict-dom@0.0.15 build:benchmarks rollup --config ./tools/rollup-benchmarks.config.js

css.create ops/sec deviation (%) samples
small 1,059,850 0.34 95
small with units 501,224 0.24 96
small with variables 647,663 0.20 96
several small 346,569 0.30 93
large 301,898 0.40 93
large with polyfills 175,443 1.29 94
complex 111,099 0.14 98
unsupported 239,730 0.22 95
css.createTheme ops/sec deviation (%) samples
simple theme 224,872 0.23 94
polyfill theme 212,966 0.09 94
css.props ops/sec deviation (%) samples
small 185,801 0.15 94
small with units 161,056 0.14 95
small with variables 93,332 0.11 94
small with variables of units 69,386 0.30 94
large 61,433 0.18 97
large with polyfills 21,041 0.94 93
complex 12,322 0.19 94
unsupported 64,548 0.31 96
simple merge 149,887 0.11 96
wide merge 10,322 1.14 96
deep merge 10,328 0.22 98
internals ops/sec deviation (%) samples
extractStyleThemes 460,434 0.12 96
flattenStyle 654,995 0.11 95