facebook / react-strict-dom

React Strict DOM (RSD) standardizes the development of styled React components for web and native.
https://facebook.github.io/react-strict-dom
MIT License
3.2k stars 161 forks source link

Polyfill logical textAlign on native #185

Closed necolas closed 3 months ago

necolas commented 3 months ago

React Native doesn't currently support logical directions for textAlign.

github-actions[bot] commented 3 months ago

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better. Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,573 2,573 1.00
· minified 8,823 8,823 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 836 836 1.00
· minified 2,365 2,365 1.00
react-strict-dom/dist/native/index.js
· compressed 15,079 15,109 1.00 +
· minified 54,914 54,987 1.00 +
github-actions[bot] commented 3 months ago

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better. Results Base Patch Ratio
css.create
· small 1,110,289 1,129,598 1.02 +
· small with units 450,985 433,904 0.96 -
· small with variables 684,895 664,868 0.97 -
· several small 333,133 322,264 0.97 -
· large 216,935 208,735 0.96 -
· large with polyfills 151,248 147,051 0.97 -
· complex 103,094 100,077 0.97 -
· unsupported 229,350 221,982 0.97 -
css.createTheme
· simple theme 223,579 220,988 0.99 -
· polyfill theme 211,184 210,581 1.00 -
css.props
· small 241,893 241,103 1.00 -
· small with units 188,764 186,802 0.99 -
· small with variables 104,976 104,655 1.00 -
· small with variables of units 74,224 73,888 1.00 -
· large 103,763 103,644 1.00 -
· large with polyfills 25,679 25,636 1.00 -
· complex 17,746 17,857 1.01 +
· unsupported 75,318 75,504 1.00 +
· simple merge 160,942 159,180 0.99 -
· wide merge 13,607 13,529 0.99 -
· deep merge 13,397 13,309 0.99 -
· themed merge 32,166 31,725 0.99 -
mellyeliu commented 3 months ago

awesome! thanks for fixing this Nicolas