search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
28.73k stars 6.34k forks source link

Fix write committed transactions replay when UDT setting toggles #13121

Closed jowlyzhang closed 3 weeks ago

jowlyzhang commented 3 weeks ago

This PR adds some missing pieces in order to handle UDT setting toggles while replay WALs for WriteCommitted transactions DB. Specifically, all the transaction markers for no op, prepare, commit, rollback are currently not carried over from the original WriteBatch to the new WriteBatch when there is a timestamp setting difference detected. This PR fills that gap.

Test plan: Added unit tests

facebook-github-bot commented 3 weeks ago

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@jowlyzhang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 weeks ago

@jowlyzhang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 weeks ago

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jowlyzhang commented 3 weeks ago

@ltamasi Thanks a lot for the quick review!

facebook-github-bot commented 3 weeks ago

@jowlyzhang merged this pull request in facebook/rocksdb@282f5a463ba0ebc0ad47d8f5aa3564046eb0eb5c.