search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
28.73k stars 6.34k forks source link

Enable attribute group APIs in the transaction stress tests #13134

Closed ltamasi closed 2 weeks ago

ltamasi commented 2 weeks ago

Summary: Even though Transaction does not currently support the attribute group variants of PutEntity / GetEntity / MultiGetEntity, we can still test the corresponding APIs of the underlying TransactionDB or OptimisticTransactionDB instance. Note: the multi-operation transaction stress test will be handled separately.

Differential Revision: D65780384

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65780384

hx235 commented 2 weeks ago

How are we currently handling the status returned by calling PutEntity / GetEntity / MultiGetEntity of the underlying TransactionDB or OptimisticTransactionDB if they are not supported operations?

ltamasi commented 2 weeks ago

How are we currently handling the status returned by calling PutEntity / GetEntity / MultiGetEntity of the underlying TransactionDB or OptimisticTransactionDB if they are not supported operations?

They are supported on the TransactionDB / OptimisticTransactionDB instance (that's the testing gap we're trying to close). The place they are not supported is the Transaction classes, where there are literally no such methods in the API (and thus there are no relevant calls in the stress test codebase).

facebook-github-bot commented 2 weeks ago

This pull request has been merged in facebook/rocksdb@7cb6b93eee097d5576c7c58f13072952e0087b77.