search

facebook / wdt

Warp speed Data Transfer (WDT) is an embeddedable library (and command line tool) aiming to transfer data between 2 systems as fast as possible over multiple TCP paths.
https://www.facebook.com/WdtOpenSource
Other
2.86k stars 392 forks source link

Option to compile wdt against libfolly rather than building libfolly4wdt subset #194

Closed hjmallon closed 3 years ago

hjmallon commented 5 years ago

Having a subset of folly build with wdt makes packaging the library and utils difficult with package managers. Is it possible / supported to build against a full version of folly?

Relevant to https://github.com/Homebrew/homebrew-core/pull/39345

TITLE WAS: "Could folly (complete) be used rather than folly4wdt?"

hjmallon commented 5 years ago

I have been able to pass all tests with a patch as follows and folly installed from brew

patch.txt

ldemailly commented 5 years ago

The reason for the current setup is that full folly is both huge and hard to build and wdt tries to have minimal dependencies. So it would make sense to have the « option » to use a prebuilt full folly but it shouldn’t be the only way nor the default

hjmallon commented 5 years ago

Having an option would be perfect. I will change the title of this issue.

ldemailly commented 5 years ago

I guess one should add code to detect if folly is already installed

hjmallon commented 5 years ago

Option in CMake for build against full folly is here https://github.com/hjmallon/wdt/commit/ec6bbad26527c34f52edae4adcbb5ada0c2b8ad3

zbeekman commented 5 years ago

A default option set to "ON" that could be set to "OFF" would be sufficient to get it into homebrew. I agree that the more suitable way to handle this, in the long run, is through CMake system introspection & find_package() etc.

If you can create a new release with an option to turn off vendored folly (following an approach like the one suggested by @hjmallon) then that would increase the chances that it can be accepted into Homebrew, which in turn helps increase adoption and visibility...