search

facebook / wdt

Warp speed Data Transfer (WDT) is an embeddedable library (and command line tool) aiming to transfer data between 2 systems as fast as possible over multiple TCP paths.
https://www.facebook.com/WdtOpenSource
Other
2.86k stars 392 forks source link

Fix compilation problems with modern versions of Folly #202

Closed SashaNullptr closed 3 years ago

SashaNullptr commented 4 years ago

Attempting to compile WDT against modern versions of Folly results in the following error when linking wdtbin (aliased to wdt).

libfolly4wdt.so: undefined reference to `folly::strlcpy(char*, char const*, unsigned long)'

It seems that the source files that define folly::strlcpy, namely lang/CString.cpp need to be included explicitly.

It also appears that this problem has already been addressed by a fork of WDT.

facebook-github-bot commented 4 years ago

Hi SashaNullptr! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

SashaNullptr commented 4 years ago

Heh, just noticed the maintainer that I linked to already submitted a PR for this problem at #201

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

davide125 commented 3 years ago

Duplicate of #201