search

facebook / wdt

Warp speed Data Transfer (WDT) is an embeddedable library (and command line tool) aiming to transfer data between 2 systems as fast as possible over multiple TCP paths.
https://www.facebook.com/WdtOpenSource
Other
2.86k stars 392 forks source link

Fix building via cmake - alternative approach #217

Closed husskade closed 3 years ago

husskade commented 3 years ago

Alternative approach to changes proposed in pull #216 to issues introduced by commit fdbc543 - simply update the C++ standard used from 14 to 17.

facebook-github-bot commented 3 years ago

Hi @husskade!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

michel-slm commented 3 years ago

@husskade saw this too late, and I'm currently landing a similar commit that also updates the comments that still mentioned C++11 and C++14. Apologies!

husskade commented 3 years ago

@husskade saw this too late, and I'm currently landing a similar commit that also updates the comments that still mentioned C++11 and C++14. Apologies!

Don't worry about it :)