search

facebook / zstd

Zstandard - Fast real-time compression algorithm
http://www.zstd.net
Other
23.85k stars 2.11k forks source link

meson: Do not export private headers in libzstd_dep to avoid name clash #4153

Closed artem closed 1 month ago

artem commented 2 months ago

This way libzstd_dep does not override, for instance,

facebook-github-bot commented 2 months ago

Hi @artem!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

artem commented 2 months ago

Signed CLA.

perhaps cc @eli-schwartz for review?

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

artem commented 2 months ago

The second commit fixes tests and contrib that I broke =)