search

facebook / zstd

Zstandard - Fast real-time compression algorithm
http://www.zstd.net
Other
23.85k stars 2.11k forks source link

Fix printing of filesize if >4GB #4199

Closed jimis closed 4 days ago

facebook-github-bot commented 1 week ago

Hi @jimis!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Cyan4973 commented 1 week ago

Thanks for the proposed patch. It looks good to me,

note that CLA compliance is a requirement before the merge.

jimis commented 1 week ago

Alright, but it might take a bit since I have to go through my employment contract first. I thought such a small fix was non-copyrightable so the CLA would not be needed.

Cyan4973 commented 1 week ago

The CLA rules are quite stringent. However, if the process becomes too complex for you, one possible solution could be to duplicate your patch and merge it under another CLA-compliant identity.

jimis commented 4 days ago

Thank you for your patience @Cyan4973, I just signed the CLA.

facebook-github-bot commented 4 days ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!