facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.
Other
3.3k stars 1.02k forks source link

Compilation Error: pointer - boolean comparison #132

Open bnlrnz opened 6 years ago

bnlrnz commented 6 years ago

https://github.com/facebookarchive/RakNet/blob/1a169895a900c9fc4841c556e16514182b75faf8/Source/ReplicaManager3.cpp#L141

Iso c++ forbids comparison between pointer and integer.

The "== false" should be removed or replaced by "== nullptr".

Luke1410 commented 6 years ago

This has already been reported before. See pull request #29 and the duplicate in #56. Most likely several RakNet forks already incorporate that fix and it's also already integrated in SLikeNet since version 0.1.0 (see https://www.slikenet.com/ if interested).