search

facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

bugfix(xcontext): Fix panic in StdCtxUntil #260

Closed xaionaro closed 3 years ago

xaionaro commented 3 years ago

I missed method StdCtxUntil in unit-tests and it appears the function does not work at all. Added an unit-test, fixed the panic and added a comment explaining how the method works.

The panic was caused by wrong usage of SetFinalizer: SetFinalizer could be assigned only to pointers to a beginning of an allocated area. Therefore it should be the first field of a structure (if the data is stored in a structure).

codecov[bot] commented 3 years ago

Codecov Report

Merging #260 (0c2ef27) into master (5e30d89) will increase coverage by 0.22%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   64.78%   65.00%   +0.22%     
==========================================
  Files         121      121              
  Lines        5404     5404              
==========================================
+ Hits         3501     3513      +12     
+ Misses       1506     1493      -13     
- Partials      397      398       +1
Flag Coverage Δ
integration 58.72% <0.00%> (-0.17%) :arrow_down:
integration_storage ∅ <ø> (?)
unittests 45.89% <100.00%> (+0.45%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/xcontext/event_handler.go 76.12% <ø> (ø)
pkg/xcontext/context.go 60.45% <100.00%> (+8.47%) :arrow_up:
pkg/cerrors/cerrors.go 0.00% <0.00%> (-14.29%) :arrow_down:
pkg/runner/test_runner.go 92.25% <0.00%> (-0.47%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e30d89...0c2ef27. Read the comment docs.