search

facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

Fix unmarshaling null step resume state #286

Closed rojer9-fb closed 3 years ago

rojer9-fb commented 3 years ago

It turns out that null unmarshals into a json.RawMessage of liteal 'null', not into nil. Add an explicit check for null.

codecov[bot] commented 3 years ago

Codecov Report

Merging #286 (b7a6d1b) into master (35d8da9) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   67.23%   67.26%   +0.03%     
==========================================
  Files         136      136              
  Lines        6607     6607              
==========================================
+ Hits         4442     4444       +2     
+ Misses       1658     1657       -1     
+ Partials      507      506       -1
Flag Coverage Δ
e2e 44.94% <100.00%> (ø)
integration 56.94% <0.00%> (-0.07%) :arrow_down:
unittests 49.29% <0.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runner/test_runner.go 92.32% <100.00%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35d8da9...b7a6d1b. Read the comment docs.