plugins/teststeps/s3fileupload/s3fileupload.go:

[llogen]

Added a new teststep that can upload a specific file to an AWS S3 Bucket. This works compressed or not. The link will be printed in the report by the Stdout Event.

Signed-off-by: llogen christophlange95@googlemail.com

[walterchris]

I would rename the plugin to something that fits better, like awsFileUpload or so, as this does not upload files in general - but rather to AWS. Or integrate AWS as an option.

[insomniacslk]

I haven't read the code and will let others review, but one thing I noticed is that the plugin name is too generic for what it does. Should this be called s3fileuploader or s3upload instead?

[insomniacslk]

ah I just noticed Chris's comment and the fact that this was renamed awsfileupload. I would say that aws is still too generic, there are hundreds of AWS services, and I would just use s3 in the name instead.

The PR title and commit messages still reference the old name, please change them as well, and squash the commits into one before merging

[rojer9-fb]

please rename the file to s3fileupload.go to align with the local naming convention

[rojer9-fb]

i think we should import and register the plugin into the default binary, so it's at least build-tested in the main repo

[codecov[bot]]

Codecov Report

Merging #298 (0ad69f6) into main (884d78e) will decrease coverage by 0.78%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   69.37%   68.58%   -0.79%     
==========================================
  Files         136      141       +5     
  Lines        7586     7991     +405     
==========================================
+ Hits         5263     5481     +218     
- Misses       1814     1955     +141     
- Partials      509      555      +46     

Flag	Coverage Δ
e2e	50.29% <ø> (+3.01%)	:arrow_up:
integration	59.75% <ø> (+0.75%)	:arrow_up:
unittests	50.30% <ø> (-0.69%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../0002_migrate_descriptor_to_extended_descriptor.go	61.49% <0.00%> (-1.97%)	:arrow_down:
cmds/contest/server/server.go	59.25% <0.00%> (-1.78%)	:arrow_down:
pkg/pluginregistry/bundles.go	64.70% <0.00%> (-1.45%)	:arrow_down:
plugins/teststeps/echo/echo.go	9.09% <0.00%> (-0.91%)	:arrow_down:
pkg/runner/test_runner.go	91.74% <0.00%> (-0.76%)	:arrow_down:
tests/integ/jobmanager/common.go	91.27% <0.00%> (-0.11%)	:arrow_down:
pkg/types/types.go	100.00% <0.00%> (ø)
plugins/listeners/httplistener/httplistener.go	42.66% <0.00%> (ø)
cmds/plugins/plugins.go
tests/plugins/targetmanagers/readmeta/readmeta.go	58.33% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 884d78e...0ad69f6. Read the comment docs.