facebookarchive / huxley

A testing system for catching visual regressions in Web applications.
Apache License 2.0
4.07k stars 286 forks source link

Huxley fails to take a screenshot #69

Open alitheg opened 10 years ago

alitheg commented 10 years ago

I've just downloaded Huxley on Windows 8.1, and added a Huxleyfile to my project. After some tussling with Firefox and Selenium versions, I finally got Huxley to launch a browser. However, when I go back to the command line and hit Enter to take a screenshot, Huxley crashes with the following error:

Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Python27\lib\threading.py", line 810, in __bootstrap_inner
    self.run()
  File "C:\Python27\lib\threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\Python27\lib\site-packages\huxley\threadpool.py", line 32, in thread
    func(*args, **kwargs)
  File "C:\Python27\lib\site-packages\huxley\cmdline.py", line 69, in run_test
    screensize=screensize
  File "C:\Python27\lib\site-packages\huxley\main.py", line 110, in main
    TestRun.record(local_d, d, (url, postdata), screensize, filename, diffcolor, sleepfactor, save_diff)
  File "C:\Python27\lib\site-packages\huxley\run.py", line 122, in record
    screenshot_step = ScreenshotTestStep(d.execute_script('return Date.now();') - start_time, run, len(steps)) TypeError: unsupported operand type(s) for -: 'unicode' and 'long'
alitheg commented 10 years ago

The crash seems to be fixed by changing this:

  screenshot_step = ScreenshotTestStep(d.execute_script('return Date.now();') - start_time, run, len(steps))

to this:

  screenshot_step = ScreenshotTestStep(d.execute_script('return Date.now().getTime();') - start_time, run, len(steps))