Outline view doesn't respect editor font

facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom

https://nuclide.io

Other

7.79k stars 683 forks source link

Outline view doesn't respect editor font #1037

Open chrislloyd opened 7 years ago

chrislloyd commented 7 years ago

Issue and Steps to Reproduce

Outline view doesn't respect the default editor font specified in Atom. .nuclide-outline-view-item overrides it to be "Menlo, Consolas, 'DejaVu Sans Mono', monospace".

Expected Behavior

When I change my default editor font, it should also update the outline view font.

Actual Behavior

Outline view font is fixed to "Menlo etc."

Versions

Atom: 1.14.3
Nuclide: 0.207.0
Client OS: OSX 10.12.3
Server OS (optional):

johnislarry commented 7 years ago

@jgebhardt has informed me that we have a long outstanding issue that underpins this problem: https://github.com/atom/atom/issues/8800, namely that determining the font family in a canonical way is non-trivial