[windows] OmniSearch broken for local projects

[Daniel15]

OmniSearch just appears to load forever when using local projects. Works fine for remote projects. This worked in older releases (1-2 months ago) but has broken since then :cry:

Possibly related exception: "Nuclide URIs must contain paths, 'null' found while parsing 'c:'""

Versions

• Atom: 1.7.4
• Nuclide: 0.142.x
• Client OS: Windows 10

  Additional Details

• Installed packages (apm ls --installed):

Community Packages (14) C:\Users\danlo\.atom\packages
├── atom-touch-events@0.23.0
├── emmet@2.4.3
├── haskell-grammar@0.4.0
├── highlight-selected@0.11.2
├── language-babel@2.17.3
├── language-ini@1.16.0
├── language-ocaml@1.1.2
├── language-thrift@1.0.2
├── merge-conflicts@1.4.4
├── nuclide@0.144.31983956
├── sort-lines@0.14.0
├── split-string-on-enter@1.0.2
├── tool-bar@0.4.0
└── visual-studio-dark-syntax@0.1.0

└── (empty)

[nmote]

cc @shushz -- possibly related to your recent paths change?

[shushz]

Hmm, don't think so. IIRC it wasn't out yet in 0.144. But, the paths change didn't fix it either. Will look into this.

[shushz]

Not sure how it ever worked. There are just too many things in this logic that are not Windows compatible due to various reasons. Most are silly, but some are rather major, such as reliance of that logic on Watchman. For the time being I'm choosing to hope that https://github.com/hansonw/fuzzy-native will be compiled for Windows, removing the need to have this logic at all.

[Daniel15]

Not sure how it ever worked.

I swear it used to work when I was testing https://github.com/facebook/nuclide/pull/435, but maybe I'm misremembering :stuck_out_tongue:

some are rather major, such as reliance of that logic on Watchman

I don't think I had Watchman installed on my old MacBook Pro? Do we actually need Watchman for local projects?