Cannot switch top level component type.

facebookarchive / react-page

Easy Application Development with React JavaScript

Apache License 2.0

797 stars 72 forks source link

Cannot switch top level component type. #20

Closed jordwalke closed 11 years ago

jordwalke commented 11 years ago

We should document the limitation here, and possibly fix this in the react core. When the top level component type switches, we can't innerHTML the entire document, so we might need to special case it. Thanks to @andreypopp for finding this one.

petehunt commented 11 years ago

Related to this, if you mess up and the server rendered checksum doesn't match you'll also have this issue.

andreypopp commented 11 years ago

I think this can be closed cause React now has a special code path for mutating <html> element.

petehunt commented 11 years ago

Fixed in https://github.com/facebook/react/commit/c8886a0424c426818566c21d5a69c4cb8f5d41e3