facebookarchive / xctool

An extension for Apple's xcodebuild that makes it easier to test iOS and macOS apps.

Apache License 2.0

6.91k stars 738 forks source link

Fixed compatibility of unit testing with Xcode 8 #709

Closed dinhvh closed 8 years ago

dinhvh commented 8 years ago

codesign libraries to make Xcode 8 beta >= 4 happy
got rid of VerifySimulators since private API SimVerifier is no more
detect frameworks being loaded through overriding NSBundle behavior
private DTiPhoneSimulatorSystemRoot API disappeared. Then we replaced it with traversing the filesystem and parsing .plist files.

@ExtremeMan

dinhvh commented 8 years ago

Let's wait unit tests to go through. I think I got all them to work but couldn't a last one because I probably don't have a proper local environment for testing.

dinhvh commented 8 years ago

704

ExtremeMan commented 8 years ago

Very nice. Have you tried running tests both under Xcode 7 and Xcode 8?

dinhvh commented 8 years ago

Surprisingly, I haven't tried the unit tests on Xcode 8. I'm doing it.

ExtremeMan commented 8 years ago

Looks like build failed. Try running ./scripts/travis-ci.sh locally.

dinhvh commented 8 years ago

Making progress: 4 tests failing instead of 6.

ExtremeMan commented 8 years ago

Very nice. Should we just drop SenTestingKit support?

dinhvh commented 8 years ago

ha yeah, everything boils down to it :) Could you give me some guidance for that? I can start with removing the unit tests and then in second pull request we can try to burn everything else SenTestingKit.

ExtremeMan commented 8 years ago

Sounds good to me. Kill all SenTestingKit tests to unblock this PR. In follow up we can assert in Xcode 6 + remove everything related to that old guy.

ExtremeMan commented 8 years ago

🎉