facebookexperimental / ExtendedAndroidTools

Extended Android Tools is a place to host and maintain a build environment and makefiles cross compiling Linux tools we all love for Android.
Apache License 2.0
189 stars 63 forks source link

Scaffolding jdwp for new JDWP debugger project #62

Closed wekesa360 closed 1 year ago

wekesa360 commented 1 year ago

This pull request addresses the issue #53, however I'm currently facing an issue with running the placeholder targets e.g buck2 run //projects/jdwp:main. An error is thrown as

From `load` at implicit location

Caused by:
    0: From `load` at prelude/prelude.bzl:8:6-29
    1: From `load` at prelude/native.bzl:15:6-45
    2: From `load` at prelude/apple/apple_macro_layer.bzl:14:5-36
    3: From `load` at prelude/apple/apple_rules_impl_utility.bzl:9:6-46
    4: From `load` at prelude/apple/apple_bundle_types.bzl:8:6-18
    5: From `load` at prelude/apple/debug.bzl:9:5-35
    6: Error evaluating module: `prelude//artifact_tset.bzl`
    7: Traceback (most recent call last):
         * prelude/artifact_tset.bzl:29, in <module>
             _tset = field([_ArtifactTSet, None], None),
       error: Found `_ArtifactTSet` instead of a valid type annotation. Perhaps you meant `"_ArtifactTSet"`?
         --> prelude/artifact_tset.bzl:29:13
          |
       29 |     _tset = field([_ArtifactTSet, None], None),
          |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          |

Build ID: 0a784514-076a-44d5-80c9-42d81616c2e8
Jobs completed: 3. Time elapsed: 0.2s.
BUILD FAILED
michalgr commented 1 year ago

Hi !

The issue you're seeing is caused by incompatible versions of buck2 and 'prelude' module. It should go away if you rebase past https://github.com/facebookexperimental/ExtendedAndroidTools/commit/35f3021bfcdad0f95fdfe1528e6e11208be95fb6.

michalgr commented 1 year ago

Looks good !

I noticed that pyre does not work yet, but we can handle that later.

Could you add the following copyright to BUCK and *.py files ?

# Copyright (c) Meta Platforms, Inc. and affiliates.