search

facebookincubator / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.
Other
2.1k stars 332 forks source link

Fixed morph target names #246

Open JordyvanDortmont opened 4 years ago

JordyvanDortmont commented 4 years ago

As mentioned in the implementation note for morph targets here: https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#morph-targets

The targetNames array and all primitive targets arrays must have the same length.

Currently the same target names are added multiple times when present on multiple mesh primitives. This causes the length of the target names to be a multiple of the length of the primitive target arrays.

facebook-github-bot commented 4 years ago

Hi JordyvanDortmont! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!