search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

Breeze fixes #11537

Closed dreveman closed 2 weeks ago

netlify[bot] commented 2 weeks ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 3eca5ae5d9d47853f576f768be51f4948186389b
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673668ca9bddf000083577f1
dreveman commented 2 weeks ago

@Yuhta I found these issues when trying to build breeze tests in ToT. The cmake change is just a result of my MR falling behind before it was merged and the other issues turned up when using ubuntu 24.04 instead of 22.04 to build.

dreveman commented 2 weeks ago

@Yuhta Added a commit that provides an autogen header for generated files as discussed

Yuhta commented 2 weeks ago

@dreveman Something to be fixed with formatter: https://github.com/facebookincubator/velox/actions/runs/11843156393/job/33008280565

dreveman commented 2 weeks ago

@dreveman Something to be fixed with formatter: https://github.com/facebookincubator/velox/actions/runs/11843156393/job/33008280565

Yeah, I'll take care of that and also include a number of changes that are needed to build perf tests and tests for other platforms after everything was moved into the breeze subdir

dreveman commented 2 weeks ago

@dreveman Something to be fixed with formatter: https://github.com/facebookincubator/velox/actions/runs/11843156393/job/33008280565

Yeah, I'll take care of that and also include a number of changes that are needed to build perf tests and tests for other platforms after everything was moved into the breeze subdir

@Yuhta Should be fixed now and this PR should be ready to be merged

dreveman commented 2 weeks ago

@Yuhta Looks like all checks passed. Anything else needed for this to be merged?

facebook-github-bot commented 2 weeks ago

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dreveman commented 2 weeks ago

@Yuhta let me know if I need to do anything to get that warning fixed?

facebook-github-bot commented 2 weeks ago

@Yuhta merged this pull request in facebookincubator/velox@31ae379d42f20b8fe39cc0ae9d873ce89bc6d593.

conbench-facebook[bot] commented 2 weeks ago

Conbench analyzed the 1 benchmark run on commit 31ae379d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.