facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

finalizeS3FileSystem not call, casu segmentation fault #8258

Open xingnailu opened 11 months ago

xingnailu commented 11 months ago

Bug description

I use gluten + velox + celebron, branch is 2023_12_25, and the following error occurs when running tpch-21: 2024-01-04T08:23:04.454125006Z stderr F I0104 08:23:04.454034 24 S3FileSystem.cpp:457] finalizeS3FileSystem() was not called even though S3 was initialized.This could lead to a segmentation fault at exit`

I want to know when we should manually call finalizeS3FileSystem? I have searched through the velox code, but I have not found any calls in the source code except in ut.

System information

Velox System Info v0.0.2 Commit: 269b85e6923782e6235658f7ace2fe22a02ba4b9 CMake Version: 3.16.3 System: Linux-5.15.0-91-generic Arch: x86_64 C++ Compiler: /usr/bin/c++ C++ Compiler Version: 9.4.0 C Compiler: /usr/bin/cc C Compiler Version: 9.4.0 CMake Prefix Path: /usr/local;/usr;/;/usr;/usr/local;/usr/X11R6;/usr/pkg;/opt

Relevant logs

No response

majetideepak commented 10 months ago

@xingnailu See comments here https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/storage_adapters/s3fs/RegisterS3FileSystem.h#L24