search

facebookresearch / 3detr

Code & Models for 3DETR - an End-to-end transformer model for 3D object detection
Apache License 2.0
629 stars 79 forks source link

Fix issues with training on point colors #37

Closed daveredrum closed 2 years ago

daveredrum commented 2 years ago

Hi there,

Just noticed this tiny issue that "use_color" option is not included into datasets.build_dataset(), albeit provided in the dataset and main.py. I've fixed the related issues and added a new training script scripts/scannet_masked_eq1080_color.sh for training with point colors.

I hope this small tweak can be helpful :)

Best Dave

facebook-github-bot commented 2 years ago

Hi @daveredrum!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

imisra commented 2 years ago

Thanks @daveredrum ! I'll merge your changes :)