jsonlines is missing as declared dependency in setup.py

facebookresearch / DPR

Dense Passage Retriever - is a set of tools and models for open domain Q&A task.

Other

1.73k stars 305 forks source link

Closed jobergum closed 3 years ago

jobergum commented 3 years ago

Hello! Small issue, but setup.py does not mention jsonlines but is used in the project, e.g https://github.com/facebookresearch/DPR/blob/main/dpr/data/tables.py#L8

vlad-karpukhin commented 3 years ago

Hi, ok, thanks for highlighting it

vlad-karpukhin commented 3 years ago

fixed